Extra fixes adata layers None after anndata X unification#1123
Merged
LucaMarconato merged 3 commits intomainfrom May 11, 2026
Merged
Extra fixes adata layers None after anndata X unification#1123LucaMarconato merged 3 commits intomainfrom
LucaMarconato merged 3 commits intomainfrom
Conversation
…rage Skip None when building new_keys so it is never passed to sanitize_name, and preserve it verbatim in new_dict so the layers setter round-trips X correctly on anndata >= 0.13 where X lives at layers[None]. Add test_sanitize_table_layers_preserves_x to verify X is intact after sanitization; the None-in-layers assertion is guarded by a pre-check so the test is valid on both anndata 0.12.x and >= 0.13. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1123 +/- ##
=======================================
Coverage 92.03% 92.03%
=======================================
Files 51 51
Lines 7761 7761
=======================================
Hits 7143 7143
Misses 618 618
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extra fix (+ tests) in
sanitize_table()after #1122